Fixes #550 Mouse position plugin improvements#561
Merged
mbarto merged 1 commit intogeosolutions-it:masterfrom May 13, 2016
Merged
Fixes #550 Mouse position plugin improvements#561mbarto merged 1 commit intogeosolutions-it:masterfrom
mbarto merged 1 commit intogeosolutions-it:masterfrom
Conversation
web/client/plugins/MousePosition.jsx
Outdated
|
|
||
| const MousePositionPlugin = connect(selector)(require('../components/mapcontrols/mouseposition/MousePosition')); | ||
| const MousePositionPlugin = connect(selector, { | ||
| copyToClipboardEnabled: true |
Contributor
There was a problem hiding this comment.
remove this, we cannot disable it in any way otherwise
83c7dcd to
44e6961
Compare
web/client/product/stores/store.js
Outdated
| } | ||
|
|
||
| // mouse position will only be show on map click | ||
| assign(newState, assign(newState.mousePosition || {}, {showOnClick: true})); |
Contributor
There was a problem hiding this comment.
We do not want this by default. Remove
44e6961 to
26a7845
Compare
Author
|
Updated, deactivating onClick and the clipboard copy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated issue: #550