Skip to content

Close #3385 Close missing save button after login#3757

Merged
offtherailz merged 2 commits intogeosolutions-it:masterfrom
kappu72:t#3385
May 16, 2019
Merged

Close #3385 Close missing save button after login#3757
offtherailz merged 2 commits intogeosolutions-it:masterfrom
kappu72:t#3385

Conversation

@kappu72
Copy link
Copy Markdown
Contributor

@kappu72 kappu72 commented May 15, 2019

Description

Fixed mapId type when calling loadMapInfo action, it needed to be a string now accepts number or string

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Map permissions are requested but on MAP_INFO_LOADED the state isn't updated

What is the new behavior?
Map permissions are requested and on MAP_INFO_LOADED the state is updated

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…e a string otherwise the reducers doesn't update the map state
@ghost ghost assigned kappu72 May 15, 2019
@tdipisa tdipisa requested a review from offtherailz May 15, 2019 16:03
@coveralls
Copy link
Copy Markdown

coveralls commented May 15, 2019

Coverage Status

Coverage decreased (-0.02%) to 81.405% when pulling 317303b on kappu72:t#3385 into 1004ad9 on geosolutions-it:master.

@offtherailz offtherailz merged commit c1f3cca into geosolutions-it:master May 16, 2019
@offtherailz offtherailz added this to the 2019.01.01 milestone May 16, 2019
offtherailz pushed a commit to offtherailz/MapStore2 that referenced this pull request May 16, 2019
kappu72 added a commit to kappu72/MapStore2 that referenced this pull request May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After login on public map you can not save

3 participants