Skip to content

Close #3695 Wrong west south coordinates#3742

Merged
offtherailz merged 2 commits intogeosolutions-it:masterfrom
kappu72:n#3693
May 10, 2019
Merged

Close #3695 Wrong west south coordinates#3742
offtherailz merged 2 commits intogeosolutions-it:masterfrom
kappu72:n#3693

Conversation

@kappu72
Copy link
Copy Markdown
Contributor

@kappu72 kappu72 commented May 10, 2019

Description

Intl number formatter has problem with -0 and 0, when passing from positive to negative or reverse it keeps the sign until the rounded value reaches 1 or -1.
The sign is now managed outside the number formatter.

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
See description

What is the new behavior?
Fixed the problem described above

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@ghost ghost assigned kappu72 May 10, 2019
@kappu72 kappu72 added this to the 2019.01.01 milestone May 10, 2019
@coveralls
Copy link
Copy Markdown

coveralls commented May 10, 2019

Coverage Status

Coverage decreased (-0.03%) to 81.401% when pulling 05680f0 on kappu72:n#3693 into ca2e60f on geosolutions-it:master.

Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a unit test for this bug

@offtherailz offtherailz merged commit 5701635 into geosolutions-it:master May 10, 2019
kappu72 added a commit to kappu72/MapStore2 that referenced this pull request May 10, 2019
offtherailz pushed a commit that referenced this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong west coordinates in mouse position

3 participants