Fix #3738 Add the possibility to customize default regex for GeoServer#3739
Merged
allyoucanmap merged 2 commits intogeosolutions-it:masterfrom May 10, 2019
Merged
Conversation
mbarto
approved these changes
May 9, 2019
MV88
requested changes
May 10, 2019
web/client/utils/LayersUtils.js
Outdated
| * default regex rule for searching for a /geoserver/ string in a url | ||
| * default constant regex rule for searching for a /geoserver/ string in a url | ||
| */ | ||
| REG_GEOSERVER_RULE, |
Contributor
There was a problem hiding this comment.
this is out of synch and seems not being used anywhere in github: see
offtherailz
reviewed
May 10, 2019
web/client/utils/LayersUtils.js
Outdated
| return regex.test(url) && url.match(regex)[0] || null; | ||
| }; | ||
|
|
||
| let REG_GEOSERVER_RULE = /\/[\w- ]*geoserver[\w- ]*\//; |
Member
There was a problem hiding this comment.
variables in lowerCamelCase
offtherailz
approved these changes
May 10, 2019
MV88
approved these changes
May 10, 2019
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this pull request
May 10, 2019
…ex for GeoServer (geosolutions-it#3739)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the possibility to override the REG_GEOSERVER_RULE in LayersUtils.
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
#3738
What is the new behavior?
It's possible to override the variable REG_GEOSERVER_RULE in LayersUtils via setRegGeoserverRule function
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: