Skip to content

Closes #2349 Improve search plugin error message#3737

Merged
offtherailz merged 2 commits intogeosolutions-it:masterfrom
kappu72:issue#2349
May 10, 2019
Merged

Closes #2349 Improve search plugin error message#3737
offtherailz merged 2 commits intogeosolutions-it:masterfrom
kappu72:issue#2349

Conversation

@kappu72
Copy link
Copy Markdown
Contributor

@kappu72 kappu72 commented May 9, 2019

Description

Added a generic error message end a specific one when the requested service type is missing

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Any error in search plugin just show error.message in the tooltip

What is the new behavior?
Added translations for generic search error and for search service type missing

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@ghost ghost assigned kappu72 May 9, 2019
@kappu72 kappu72 added this to the 2019.01.01 milestone May 9, 2019
@coveralls
Copy link
Copy Markdown

coveralls commented May 9, 2019

Coverage Status

Coverage increased (+0.04%) to 81.433% when pulling b969a3a on kappu72:issue#2349 into d9add06 on geosolutions-it:master.

@kappu72 kappu72 closed this May 9, 2019
@kappu72 kappu72 reopened this May 9, 2019
@offtherailz offtherailz merged commit 60d41a9 into geosolutions-it:master May 10, 2019
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented May 10, 2019

@kappu72 please backport this to the 2019.01.xx branch.

kappu72 added a commit to kappu72/MapStore2 that referenced this pull request May 10, 2019
offtherailz pushed a commit that referenced this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Search Plugin error message when a service is not registered

4 participants