Skip to content

Closes #3534 No result on one content tab cause switch to the other tab (maps/dashboards)#3733

Merged
offtherailz merged 3 commits intogeosolutions-it:masterfrom
kappu72:issue#3534
May 9, 2019
Merged

Closes #3534 No result on one content tab cause switch to the other tab (maps/dashboards)#3733
offtherailz merged 3 commits intogeosolutions-it:masterfrom
kappu72:issue#3534

Conversation

@kappu72
Copy link
Copy Markdown
Contributor

@kappu72 kappu72 commented May 8, 2019

Description

ContentTabs switch correctly between maps and dashboards when reloaded.

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
ContentTabs doesn't automatically switch to content with elements if the current content hasn't.

What is the new behavior?
ContTabs switch to first content with elements if the current hasn't

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@ghost ghost assigned kappu72 May 8, 2019
@kappu72 kappu72 added this to the 2019.01.01 milestone May 8, 2019
@coveralls
Copy link
Copy Markdown

coveralls commented May 8, 2019

Coverage Status

Coverage increased (+0.02%) to 81.375% when pulling 8c6c9a9 on kappu72:issue#3534 into d3a2a2a on geosolutions-it:master.

@ghost ghost assigned offtherailz May 9, 2019
Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only indentation notes.

@offtherailz offtherailz changed the title Closes #3534 Closes #3534 Switch to maps or dashboards tab when 0 result May 9, 2019
@offtherailz offtherailz changed the title Closes #3534 Switch to maps or dashboards tab when 0 result Closes #3534 No result on one content tab cause switch to the other tab (maps/dashboards) May 9, 2019
@offtherailz offtherailz merged commit 5c8f7e9 into geosolutions-it:master May 9, 2019
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented May 10, 2019

@kappu72 please backport this to the 2019.01.xx branch.

kappu72 added a commit to kappu72/MapStore2 that referenced this pull request May 10, 2019
offtherailz pushed a commit that referenced this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Home page search of Map and Dashboard

4 participants