Closes #3385 After login on public map you can not save#3730
Closes #3385 After login on public map you can not save#3730offtherailz merged 1 commit intogeosolutions-it:masterfrom
Conversation
| zoomToExtent | ||
| } = require('../../actions/map'); | ||
|
|
||
| const {MAP_INFO_LOAD_START} = require('../../actions/config'); |
There was a problem hiding this comment.
i think we have added the mapstore alias
do for new code we can use it
const {MAP_INFO_LOAD_START} = require('@mapstore/actions/config');
can you change that ?
can you do it also for other requires?
| const assign = require('object-assign'); | ||
| const {Glyphicon} = require('react-bootstrap'); | ||
| const Message = require('../components/I18N/Message'); | ||
| const {loadMapInfo} = require('../actions/config'); |
There was a problem hiding this comment.
this should affect also the component, can you check that?
| changeMapView | ||
| } = require('../actions/map'); | ||
| const {mapSelector} = require('../selectors/map'); | ||
| const {mapSelector, mapIdSelector} = require('../selectors/map'); |
There was a problem hiding this comment.
same here @mapstore/ bla bla bla
offtherailz
left a comment
There was a problem hiding this comment.
I'm afraid you didn't solved the issue. please check this action is emitted in the application.
| action$.ofType(LOGIN_SUCCESS) | ||
| .map(() => { | ||
| const mapId = mapIdSelector(getState()); | ||
| return loadMapInfo(ConfigUtils.getConfigProp("geoStoreUrl") + "extjs/resource/" + mapId, mapId); |
There was a problem hiding this comment.
Triggering a thunk in an epic do not work as far as I know. loadMapInfo is a thunk.
Are you sure this works?
There was a problem hiding this comment.
Since this f1f9a27 thunkmiddleware is applied before redux-observable and so It's possible to dispatch from an epic. https://stackoverflow.com/questions/48510274/use-of-redux-thunk-with-redux-observable
There was a problem hiding this comment.
Ok I verified that this issue was present during the first 6 months we used redux-observable, but due to the refactor, this usage is allowed. So I think it can be approved.
|
@kappu72 please backport this to the 2019.01.xx branch. |
…tions-it#3730) (cherry picked from commit 27f0704)
Description
Update map permissions after login
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
Map permissions aren't updated after login success
What is the new behavior?
Map permissions are updated after login
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: