Fix #3415 Layer properties are not accessible if its style is invalid#3719
Merged
tdipisa merged 2 commits intogeosolutions-it:masterfrom May 6, 2019
Merged
Conversation
offtherailz
reviewed
May 6, 2019
| status = selectedLayers.length > 1 & selectedGroups.length === 0 ? 'LAYERS' : status; | ||
| status = selectedGroups.length > 1 && !isSingleGroup ? 'GROUPS' : status; | ||
| status = this.props.selectedLayers.length > 0 && this.props.selectedLayers.filter(l => l.loadingError === 'Error').length === this.props.selectedLayers.length ? 'LAYERS_LOAD_ERROR' : status; | ||
| status = this.props.selectedLayers.length > 0 && this.props.selectedLayers.filter(l => l.loadingError === 'Error').length === this.props.selectedLayers.length ? `${status}_LOAD_ERROR` : status; |
Member
There was a problem hiding this comment.
please document getStatus. Is not too much clear what are the possible states of status. Please include all the definitions
offtherailz
reviewed
May 6, 2019
Member
offtherailz
left a comment
There was a problem hiding this comment.
I see the fix, but is not clear anymore what are the possible statuses. Please document the getStatus function in order to clarify the possibile return values and their meaning
offtherailz
approved these changes
May 6, 2019
Member
|
@allyoucanmap please provide a backport to 2019.01.xx |
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this pull request
May 6, 2019
…tyle is invalid (geosolutions-it#3719) * enabled settings on layer with error * add documentation for get status
offtherailz
pushed a commit
that referenced
this pull request
May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the possibility to access the settings of a layer even if it has error so if a setting causes an error is possible to update it.
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
#3415
What is the new behavior?
It's possible to access layer properties even if there is an error
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: