autoDetectCORS option for proxy config#3675
Merged
mbarto merged 2 commits intogeosolutions-it:masterfrom Apr 8, 2019
Merged
Conversation
offtherailz
reviewed
Apr 5, 2019
offtherailz
reviewed
Apr 5, 2019
Member
offtherailz
left a comment
There was a problem hiding this comment.
Cool. Did you solved the without updating axios for error management?
Contributor
Author
|
@offtherailz I probably forgot to commit package.json, I have to check again... |
mbarto
added a commit
that referenced
this pull request
Apr 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optional configuration to introduce autodetect of CORS on services used by MapStore2.
If enabled, when contacting any service, MS2 will try to contact it directly, on error will fallback to using the proxy (and continue to use the proxy for following requests).
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
CORS is enabled only if an host is listed in useCORS configuration option.
What is the new behavior?
CORS is autodetected and proxy is only used as a fallback.
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: