Skip to content

Fix #3531 collapsible hidden widgets#3604

Merged
offtherailz merged 6 commits intogeosolutions-it:masterfrom
offtherailz:fix_hidden_widgets
Mar 8, 2019
Merged

Fix #3531 collapsible hidden widgets#3604
offtherailz merged 6 commits intogeosolutions-it:masterfrom
offtherailz:fix_hidden_widgets

Conversation

@offtherailz
Copy link
Copy Markdown
Member

@offtherailz offtherailz commented Mar 8, 2019

Description

This pull request allow to collapse hidden widgets, when the user can see them.

Note for testers

There is no way to test this if you don't have the hide tool activated. dev server don't have it activated

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

What is the current behavior? (You can also link to an open issue here)
Admin can see hidden widgets but can not collapse them

What is the new behavior?
Hidden widgets are as the other widgets for the admin.

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

@offtherailz offtherailz marked this pull request as ready for review March 8, 2019 11:15
@offtherailz offtherailz requested a review from MV88 March 8, 2019 11:19
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 8, 2019

Coverage Status

Coverage increased (+0.008%) to 80.965% when pulling 102440c on offtherailz:fix_hidden_widgets into 9741108 on geosolutions-it:master.

@offtherailz offtherailz changed the title Fix collapsible hidden widgets Fix #3531 collapsible hidden widgets Mar 8, 2019
Copy link
Copy Markdown
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check my comments

MV88 and others added 3 commits March 8, 2019 14:13
Co-Authored-By: offtherailz <offtherailz@gmail.com>
Co-Authored-By: offtherailz <offtherailz@gmail.com>
Co-Authored-By: offtherailz <offtherailz@gmail.com>
@offtherailz offtherailz requested a review from MV88 March 8, 2019 13:21
@offtherailz offtherailz merged commit 891f3db into geosolutions-it:master Mar 8, 2019
offtherailz added a commit to offtherailz/MapStore2 that referenced this pull request Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Widgets collapse/pin/hide functionalities

4 participants