Skip to content

Fix #3578. Fix issues with layernames containing points#3579

Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom
offtherailz:fix_#3578
Feb 27, 2019
Merged

Fix #3578. Fix issues with layernames containing points#3579
offtherailz merged 1 commit intogeosolutions-it:masterfrom
offtherailz:fix_#3578

Conversation

@offtherailz
Copy link
Copy Markdown
Member

@offtherailz offtherailz commented Feb 27, 2019

Description

This solves various issues with featureType names cotaining points.

  • FeatureGrid attribute columns didn't show
  • QueryForm filter was not correctly reloaded when close and re-open
  • Attributes was not correctly loaded by the query form
  • Editing geometry (geometry type was always not compatible with editing)
  • Initial load of featureType any time open the feature grid ( no errors, it's only it didn't use the describeFeatureType cache)

note: I put in common some duplicated state access code here and there that had the same issue.

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

What is the current behavior? (You can also link to an open issue here)
FeatureGrid and QueryForm didn't work with layers with points in the name

What is the new behavior?
FeatureGrid and QueryForm work correctly for layers that has a point in the name.

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Copy link
Copy Markdown
Contributor

@mbarto mbarto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 80.902% when pulling 5cac5b3 on offtherailz:fix_#3578 into eefc654 on geosolutions-it:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FeatureGrid do not display attributes if layerName contains '.' Can not parse featureType when workspaces contain dots

5 participants