Fix #3523 improved search tool#3544
Merged
tdipisa merged 4 commits intogeosolutions-it:masterfrom Feb 19, 2019
Merged
Conversation
mbarto
suggested changes
Feb 19, 2019
web/client/epics/search.js
Outdated
| dashArray: '', | ||
| fillColor: '#3388ff', | ||
| fillOpacity: 0.2, | ||
| iconUrl: "https://cdn.rawgit.com/pointhi/leaflet-color-markers/master/img/marker-icon-red.png", |
Contributor
There was a problem hiding this comment.
can we use a local copy of this one?
Contributor
Author
There was a problem hiding this comment.
yes, i was thinking that if one overrides the resultsStyle of the Search plugin this style will be different. i'll check if we can find it from the state, (my guess is that from the config is passed to the plugin but not in the state :) )
Contributor
There was a problem hiding this comment.
My comment was about not depending from an external url that could disappear.
Contributor
Author
There was a problem hiding this comment.
i know, that's why i started with a yes... 🥇
web/client/epics/search.js
Outdated
| fillColor: '#3388ff', | ||
| fillOpacity: 0.2, | ||
| iconUrl: "https://cdn.rawgit.com/pointhi/leaflet-color-markers/master/img/marker-icon-red.png", | ||
| shadowUrl: "https://cdnjs.cloudflare.com/ajax/libs/leaflet/1.3.1/images/marker-shadow.png" |
Contributor
There was a problem hiding this comment.
I suppose we should already have a local copy of this
web/client/plugins/Search.jsx
Outdated
| })); | ||
|
|
||
| const SearchBar = connect(searchSelector, { | ||
| // ONLY FOR SAMPLE - The final one will get from state and simply call textSearch |
| position: 4 | ||
| } | ||
| }), | ||
| SearchServicesConfigPlugin: assign(SearchServicesPlugin), |
mbarto
approved these changes
Feb 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr adds up to the previous #3524
It has:
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
the search results are not reset when switching tool and search service config is under general settings
What is the new behavior?
those problems are gone and new ui has been implemented
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: