Fix #3523 add coordinated editor in search bar#3524
Merged
tdipisa merged 4 commits intogeosolutions-it:masterfrom Feb 14, 2019
Merged
Fix #3523 add coordinated editor in search bar#3524tdipisa merged 4 commits intogeosolutions-it:masterfrom
tdipisa merged 4 commits intogeosolutions-it:masterfrom
Conversation
mbarto
suggested changes
Feb 14, 2019
| const UPDATE_ADDITIONAL_LAYER = 'ADDITIONALLAYER:UPDATE_ADDITIONAL_LAYER'; | ||
| const UPDATE_OPTIONS_BY_OWNER = 'ADDITIONALLAYER:UPDATE_OPTIONS_BY_OWNER'; | ||
| const REMOVE_ADDITIONAL_LAYER = 'ADDITIONALLAYER:REMOVE_ADDITIONAL_LAYER'; | ||
| const REMOVE_ALL_ADDITIONAL_LAYER = 'ADDITIONALLAYER:REMOVE_ALL_ADDITIONAL_LAYER'; |
Contributor
There was a problem hiding this comment.
REMOVE_ALL_ADDITIONAL_LAYERS
| * @memberof actions.additionallayers | ||
| * @return {object} of type `REMOVE_ALL_ADDITIONAL_LAYER` | ||
| */ | ||
| const removeAllAdditionalLayer = () => ({ |
| /** | ||
| This component can render an input field in two different formats: 'decimal' or 'aeronautical' | ||
| */ | ||
| class CoordinateEntry extends React.Component { |
Contributor
There was a problem hiding this comment.
This is not annotations related, I would move it elsewhere
| }} = {}) => { | ||
| const renderButtons = () => buttons.map( | ||
| ({ visible = true, ...props }, index) => visible | ||
| ? (isFunction(props.el) && <props.el key={props.key || index} {...props} /> || <ToolbarButton key={props.key || index} {...btnDefaultProps} {...props} />) |
Contributor
There was a problem hiding this comment.
isFunction won't catch any possible component type. Do you need el in the ToolbarButton use case? If not, you can simply check if props.el is defined here.
mbarto
approved these changes
Feb 14, 2019
This was referenced Feb 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr will add coordinate editor (decimal or aeronautical) in the search bar
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
you cannot zoom to a specific point with the search bar in the ma viewer
What is the new behavior?
you can configure the search bar to show a coordinate editor and use it to zoom into a specific point
zoom level is configurable, for more details see the issue
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
It will also add support for overlay vector layers in the additionallayers state