Fix #3531 Add collapse/pin/hide functionalities to the widgets#3535
Merged
offtherailz merged 26 commits intogeosolutions-it:masterfrom Feb 19, 2019
Merged
Fix #3531 Add collapse/pin/hide functionalities to the widgets#3535offtherailz merged 26 commits intogeosolutions-it:masterfrom
offtherailz merged 26 commits intogeosolutions-it:masterfrom
Conversation
Hide and lock have some issues with collapse functionality. Rules applied to display/hide widgets are at plugin level. Instead they should be at global level, to be shared between Widgets and WidgetsTrey plugins. This minimal solution is hide to everyone (so even the user that can hide the widget) the widget in the tray.
…into fix_C125_#101
MV88
requested changes
Feb 14, 2019
| /** | ||
| * Collapse/Expand all the widgets | ||
| */ | ||
| const toggleCollapseAll = (target = DEFAULT_TARGET) => ({ |
Member
Author
There was a problem hiding this comment.
It's tested with the reducer, anyway, I need to add a test for the action itself
| * Collapse/Expand the widget | ||
| * @param {object} widget the widget to collapse | ||
| */ | ||
| const toggleCollapse = (widget, target = DEFAULT_TARGET) => ({ |
Contributor
There was a problem hiding this comment.
test for this, i know it is an action but you choose
Member
Author
There was a problem hiding this comment.
tested with the reducer, anyway, I need to add a test for the action itself
| @@ -0,0 +1,92 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
should we move this in components/security/enhancers?
Member
Author
There was a problem hiding this comment.
security folder is now dedicated to user, group, and permission editor. This is a different thing, so I'm afraid placing it there may be misleading
| @@ -0,0 +1,27 @@ | |||
| /* | |||
| * Copyright 2018, GeoSolutions Sas. | |||
Member
Author
There was a problem hiding this comment.
Some of these files has been created in 2018 😄
allyoucanmap
approved these changes
Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this changes:
pin)Pin
These tools are implemented as icons on the top left corner of a widget
Pinned widgets look like this:
The pin tool is not visible to users that are not able to pin/unpin widgets. By default, only admin can pin (configurable).
Collapse
Collapsed widget appear in a tray
When collapse a widget, the tray expands. You can collapse all widgets at once using the "collapse all" button in the tray
Hide
The hide functionality is disabled by default. If configured (in localConfig.json), a user that belongs to a certain role can be able to hide a widget to other users.
Add image to text widget
When you edit/create a widget, the WYSIWYG editor have the tool to add images.
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
Nor of features in #3531 is present
What is the new behavior?
Widgets are collapsible
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other information: