fixing the elevation altering bug and rang/playback conflict#3340
Merged
offtherailz merged 1 commit intogeosolutions-it:c127_geonode_integrationfrom Nov 16, 2018
Merged
Conversation
offtherailz
approved these changes
Nov 16, 2018
mbarto
reviewed
Nov 16, 2018
| * while maintaning other dimensions information in state.layer, | ||
| * it also creates a list of dimensions (from descibeDomains) in state.dimensions. | ||
| * */ | ||
| const timeDimensionData = dimensions.filter(d => d.name === 'time').reduce(el => el); |
Contributor
There was a problem hiding this comment.
I think this is going to fail if filtered dimensions array is empty, I usually use lodash head in these cases:
const timeDimensionData = head(dimensions.filter(d => d.name === 'time'));
Contributor
Author
There was a problem hiding this comment.
this whole observer is triggered if dimensions.length > 0 ( line 54 )
Contributor
There was a problem hiding this comment.
but if dimensions does not contain a time dimension, the filtered array will be empty, and reduce would crash
Contributor
Author
There was a problem hiding this comment.
@offtherailz I can fix this with the localization PR, or should I do it in a separate PR?
Contributor
There was a problem hiding this comment.
just tried in a dev console of Chome
[].reduce(e => e)
VM19016:1 Uncaught TypeError: Reduce of empty array with no initial value
at Array.reduce (<anonymous>)
at <anonymous>:1:4
(anonymous) @ VM19016:1
[].reduce(e => e, {})
{}
:)
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
see #3338
What is the new behavior?
elevation data is rendered normally
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: