Fix #3316 Style editor role management, Fix #3317 TOCItemSettings doesn't save from alert modal#3318
Merged
allyoucanmap merged 1 commit intogeosolutions-it:c127_geonode_integrationfrom Nov 8, 2018
Conversation
kappu72
approved these changes
Nov 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add editingAllowedRoles to define roles with permission
eg:
editingAllowedRoles: ['ADMIN'] only admin can edit
editingAllowedRoles: null all roles can edit
This PR fixes also a bug while saving from modal in TOCItemSettings
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
only ADMIN can edit in style editor
What is the new behavior?
MapStore can be configured to set roles with edit permission in style editor
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: