Fix #3243 circle radius problem for openlayers#3246
Fix #3243 circle radius problem for openlayers#3246offtherailz merged 5 commits intogeosolutions-it:masterfrom
Conversation
| * TODO extend it to the other tests | ||
| */ | ||
| const renderDrawSupport = (props = {}) => { | ||
| ReactDOM.render(<DrawSupport {...props}/>, document.getElementById("container")); |
There was a problem hiding this comment.
You don't reduce the boilerplate if you use it only in one place / test.
It's useful to refactor code in external functions if they are used at least in a bunch of different places, expecially in tests, where being able to read the full test at once is more important than duplication.
If you have too much code in one test it's better to split it in two different tests.
There was a problem hiding this comment.
I created this function Because i wanted to write less code in particular the parts
ReactDOM.render(<COMPONENT {props}/>, document.getElementById("container"));
I could generalize it so we can use it in general and also in other places, but I see that you prefer the older version.
Going to refactor this.
…o 3243_circle_radius_ol # Conflicts: # web/client/components/map/openlayers/DrawSupport.jsx
Description
see title
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
now the radius keeps the value inserted in the geometry details form.
What is the new behavior?
see #3243
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: