Fix #2965 Authentication Popup#3190
Conversation
MV88
left a comment
There was a problem hiding this comment.
see if any of my comments are useful
web/client/plugins/FeedbackMask.jsx
Outdated
| const Message = require('../components/I18N/Message'); | ||
| const HTML = require('../components/I18N/HTML'); | ||
|
|
||
| const feedbackMaskSelector = createSelector([ |
There was a problem hiding this comment.
just a simple note, this can go to its selectors.js file? not sure if you reuse it though
web/client/plugins/FeedbackMask.jsx
Outdated
| </Button> | ||
| ); | ||
|
|
||
| const MaskBody = emptyState( |
There was a problem hiding this comment.
@MV88 @mbarto @offtherailz This is not a reusable component but related to this plugin.
Where should I move this component to test it?
There was a problem hiding this comment.
This is an error view like the typical 404 not found page, or access denied.
We could reuse it in the future. For the moment is limited to 2 use cases (dashboards and maps), but it can be refactored quickly (not now, when another use case is required).
@mbarto what do you think about components/security or a new components/errors ?
About the name, instead of MaskBody, something like ResourceUnavailable ?
There was a problem hiding this comment.
components/errors is ok, and I agree with the ResourceUnavailable name
web/client/plugins/FeedbackMask.jsx
Outdated
| @@ -0,0 +1,98 @@ | |||
| /** | |||
| * Copyright 2016, GeoSolutions Sas. | |||
| .filter( (action) => action.error && action.error.status === 403 && !isLoggedIn(store.getState())) | ||
| .switchMap(() => { | ||
| return Rx.Observable.of(setControlProperty('LoginForm', 'enabled', true, true)); | ||
| return Rx.Observable.of(setControlProperty('LoginForm', 'enabled', true)) |
Description
This PR introduces FeedbackMask plugin.
This plugin provides a mask for maps or dashboard not fount or not accessible.
others changes:
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
Maps or dashborad not found or not accessible don't show clear messages and login modal it's not manage correctly
What is the new behavior?
Added a plugin to show feedbacks for maps/dashboards when they ara a load error
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
It's needed an update in localConfig.json anb plugins.js of projects