Fix #2965 Authentication Popup#3171
Merged
offtherailz merged 5 commits intogeosolutions-it:2018.02.00from Sep 4, 2018
Merged
Conversation
offtherailz
requested changes
Aug 29, 2018
Member
There was a problem hiding this comment.
The General Idea and the look is really good.
Bugs:
- Login from home page, then open "new dashboard" and logout, you see "Loading MapStore" spinner forever.
Some considerations:
- The "Loading MapStore" text is correct for initial loading, but when you're loading a map or a dashboard, you should show a "Loading Map", "Loading Dashboard" or a generic "Loading" message. In this case the message could also be localized (we already have localization in most of the cases)
- A message inside the login prompt (or a notification) that explains why the login is required should be shown
- The messages have a small font. If possible, I suggest to make both home button and text a little bigger
- The button should show the text "Back to home page", that is more correct that "Go Home". I think is better to show the text in the button instead of the tooltip, you have enough space to show a button with text
offtherailz
approved these changes
Sep 3, 2018
Member
|
The other consideration can be postponed, if it is not trivial to be implemented: |
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this pull request
Sep 11, 2018
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this pull request
Sep 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces FeedbackMask plugin.
This plugin provides a mask for maps or dashboard not fount or not accessible.
others changes:
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
Maps or dashborad not found or not accessible don't show clear messages and login modal it's not manage correctly
What is the new behavior?
Added a plugin to show feedbacks for maps/dashboards when they ara a load error
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
It's needed an update in localConfig.json anb plugins.js of projects