Skip to content

adding some translations#3185

Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom
baloola:some_translations
Sep 27, 2018
Merged

adding some translations#3185
offtherailz merged 1 commit intogeosolutions-it:masterfrom
baloola:some_translations

Conversation

@baloola
Copy link
Copy Markdown
Contributor

@baloola baloola commented Sep 9, 2018

Description

this PR fixes some translations, see the issues

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?
text in mentioned titles and buttons is translated to the selected language

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@ghost ghost assigned baloola Sep 9, 2018
@coveralls
Copy link
Copy Markdown

coveralls commented Sep 9, 2018

Coverage Status

Coverage decreased (-0.04%) to 80.876% when pulling 3ea22ef on baloola:some_translations into d6704ff on geosolutions-it:master.

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Sep 27, 2018

@baloola, this needs a PR to be backported to the stable branch 2018.02.xx too.

@tdipisa tdipisa requested a review from offtherailz September 27, 2018 08:23
@offtherailz offtherailz merged commit a40cf82 into geosolutions-it:master Sep 27, 2018
"titleTranslations": "Title translations",
"groupProperties": "Group properties",
"titleTranslations": "Titel Übersetzungen",
"groupProperties": "Proprietà del gruppo",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Proprietà del gruppo" is Italian, it should be "Gruppeneigenschaften"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some remaining translation to do Group properties window localization

4 participants