Fix #3153 Embedded doesn't work on ie11 #3176
Merged
offtherailz merged 2 commits intogeosolutions-it:masterfrom Sep 4, 2018
Merged
Fix #3153 Embedded doesn't work on ie11 #3176offtherailz merged 2 commits intogeosolutions-it:masterfrom
offtherailz merged 2 commits intogeosolutions-it:masterfrom
Conversation
offtherailz
approved these changes
Sep 3, 2018
Member
offtherailz
left a comment
There was a problem hiding this comment.
Good, we can open an issue for the future to remove object-assign lib in favour of Object.assign.
@mbarto do you agree to add a file that includes all needed dependencies for polyfills and so on?
Contributor
|
@offtherailz I agree |
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this pull request
Sep 4, 2018
allyoucanmap
added a commit
that referenced
this pull request
Sep 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a file where list and require polyfills.
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
Embedded dosn't work in ie11 because missing Object.assign polyfill
error related to file
react-dock/lib/Dock.jsWhat is the new behavior?
Embedded loads the map viewer
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Verify use and location of StandardApp in others projects