Temporary disabling the terrain#3165
Conversation
| let {type, ...tpOptions} = rawOptions.terrainProvider; | ||
| switch (type) { | ||
| case "cesium": { | ||
| overrides.terrainProvider = new Cesium.CesiumTerrainProvider(tpOptions); |
There was a problem hiding this comment.
I think this should stay as is is if it can work after the API changes, with new options
The case entry, otherwise, removed.
If a terrainProvider must be added, you should instead change the default terrainProvider option to "ellipsoid" (in viewer and localConfig, and add an entry in this switch case for "ellipsoid", that is also the switch case "default".
doing this, also if we do not support cesium anymore, the switch will fall back to ellipsoid.
There was a problem hiding this comment.
Sorry, I didn't see the comment in the related issue. So please change the defaults (viewer and localConfig) and add a default/ellipsoid entry to this switch. It is a cleaner solution.
| terrainProvider: { | ||
| type: "cesium", | ||
| type: "ellipsoid", | ||
| url: "https://assets.agi.com/stk-terrain/world", |
There was a problem hiding this comment.
I know I'm boring, but url and requestVertexNormals are not needed anymore, please leave only "type"
There was a problem hiding this comment.
of course the same in the other file, please always remove lines of code and configurations that are not needed
Description
the terrain provider was disabled, the app renders the ellipsoid instead.
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: