Fix #2983 remove + button when loading an existing dashboard (#2983)#3011
Merged
offtherailz merged 4 commits intogeosolutions-it:masterfrom Jun 21, 2018
Merged
Fix #2983 remove + button when loading an existing dashboard (#2983)#3011offtherailz merged 4 commits intogeosolutions-it:masterfrom
offtherailz merged 4 commits intogeosolutions-it:masterfrom
Conversation
offtherailz
requested changes
Jun 19, 2018
| hasConnections: groups.length > 0, | ||
| hasWidgets, | ||
| canEdit: (resource ? resource.canEdit : true), | ||
| canEdit: (resource ? resource.canEdit : (isNaN(path.substr(-4))) ? true : false), |
Member
There was a problem hiding this comment.
Seems a good solution.
Can you isolate canEdit in a selector for dashboard and write a unit test?
MV88
requested changes
Jun 20, 2018
| getWidgetsDependenciesGroups, | ||
| (showConnections, logged, resource, hasWidgets, groups = []) => ({ | ||
| pathnameSelector, | ||
| (showConnections, logged, resource, hasWidgets, groups, path = []) => ({ |
Contributor
There was a problem hiding this comment.
here groups are losing the default value, is it intended?
Contributor
Author
There was a problem hiding this comment.
i couldn't detect a change in groups value.
Could you elaborate please
Contributor
There was a problem hiding this comment.
with this pr you are removing = [] from groups property.
you should restore it like this
(showConnections, logged, resource, hasWidgets, groups = [], path = [])
Contributor
|
Just a minor thing. |
offtherailz
approved these changes
Jun 21, 2018
offtherailz
pushed a commit
to offtherailz/MapStore2
that referenced
this pull request
Jul 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR provide a fix for the issue below
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
#2983
What is the new behavior?
dashboard editor with the connect button, when the page is loading. In the case of new dashboard entry point it appears normally
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
the test was conducted in chromium