Skip to content

Closes #2418 Added spatial filter customizable methods#2431

Merged
offtherailz merged 5 commits intogeosolutions-it:masterfrom
MV88:2418_query_builder_regions
Nov 29, 2017
Merged

Closes #2418 Added spatial filter customizable methods#2431
offtherailz merged 5 commits intogeosolutions-it:masterfrom
MV88:2418_query_builder_regions

Conversation

@MV88
Copy link
Copy Markdown
Contributor

@MV88 MV88 commented Nov 28, 2017

Description

Added the possibility to configure a method which queries a layer on geoserver and fetches the features' geometries used to create a cql filter (spatial) in combination with the geometric operation.

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Feature

What is the current behavior? (You can also link to an open issue here)
It was not possible to configure such a method.

What is the new behavior?
it is possible, see documentation

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

@MV88 MV88 self-assigned this Nov 28, 2017
@MV88 MV88 requested a review from offtherailz November 28, 2017 09:57
@ghost ghost added In Test labels Nov 28, 2017
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.3%) to 80.815% when pulling 5ccc676 on MV88:2418_query_builder_regions into 98d7440 on geosolutions-it:master.

@MV88 MV88 changed the title Closes #2418 Added spatial fitler customizable methods Closes #2418 Added spatial filter customizable methods Nov 28, 2017
@geosolutions-it geosolutions-it deleted a comment Nov 28, 2017
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.3%) to 80.815% when pulling 5ccc676 on MV88:2418_query_builder_regions into 98d7440 on geosolutions-it:master.

@geosolutions-it geosolutions-it deleted a comment Nov 28, 2017
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 80.931% when pulling c5cd1b9 on MV88:2418_query_builder_regions into 98d7440 on geosolutions-it:master.

@tdipisa tdipisa removed the In Test label Nov 28, 2017
* "queriableAttributes": ["ATTRIBUTE_X"],
* "typeName": "workspace:typeName",
* "valueField": "ATTRIBUTE_Y",
* "returnFullData": true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be an option.

const {AutocompleteWFSCombobox} = require('./AutocompleteWFSCombobox');
const {createWFSFetchStream} = require('../../observables/autocomplete');

class AutocompleteWFSComboboxContainer extends React.Component {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this class the stream directly on rendering.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree, i'll make the change.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.07%) to 81.002% when pulling 5223d5c on MV88:2418_query_builder_regions into 98d7440 on geosolutions-it:master.

@geosolutions-it geosolutions-it deleted a comment Nov 29, 2017
@offtherailz offtherailz merged commit ac62205 into geosolutions-it:master Nov 29, 2017
@ghost ghost removed the pending review label Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an option to query panel to filter by WFS geometry

4 participants