Fix #11646 baselayer selector doesn't adjust to the map after Save#11884
Merged
allyoucanmap merged 2 commits intogeosolutions-it:masterfrom Jan 23, 2026
Merged
Conversation
1 task
anup39
reviewed
Jan 22, 2026
| * This ensures annotations.editing is reset to fix layout calculation issues | ||
| */ | ||
| export const closeAnnotationsOnMapInfoLoadedEpic = (action$, { getState }) => | ||
| action$.ofType(MAP_INFO_LOADED) |
Member
There was a problem hiding this comment.
@subashtiwari1010 I think MAP_SAVED is the correct action to listen. However MAP_INFO_LOADED also works. Just wanted to know which is better in this case.
Contributor
Author
There was a problem hiding this comment.
Here, as the refresh of the map data is occuring due to the MAP_INFO_LOADED, so we need to listen to that action so no further issues arises. As, all the closing of the annotation panel and calculation of the map layout needs to be done during that time.
anup39
approved these changes
Jan 22, 2026
anup39
approved these changes
Jan 22, 2026
Contributor
|
@ElenaGallo please test this fix on dev and let us know if we can backport, thanks |
Contributor
|
Test passed, @anup39 please backport. Thanks |
Member
|
Successfully created backport PR for |
tdipisa
pushed a commit
that referenced
this pull request
Feb 3, 2026
allyoucanmap
pushed a commit
that referenced
this pull request
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue of position of the baselayer selector on the map after editing the annotation and saving.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
The baselayer selector remains in the same position without adapting to the map's resizing.
#11646
What is the new behavior?
The baselayer selector reposition itself in bottom-left with a small margin.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information