Skip to content

#11803: Time dimension: Reload not working, when the last feature is not anymore valid#11804

Merged
MV88 merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:issue_11803
Dec 12, 2025
Merged

#11803: Time dimension: Reload not working, when the last feature is not anymore valid#11804
MV88 merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:issue_11803

Conversation

@mahmoudadel54
Copy link
Copy Markdown
Contributor

Description

This PR includes handling refreshing wms layer if there a loading error detecting. This fixes the issue of keeping cache tiles on map if user filters with date not included in the layer data from the time dimension filter.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
#11803

What is the new behavior?

If the layer filtered by a date not included in the layer data, a layer refresh happens to update map.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@mahmoudadel54 mahmoudadel54 requested a review from MV88 December 11, 2025 17:52
@mahmoudadel54 mahmoudadel54 self-assigned this Dec 11, 2025
@mahmoudadel54 mahmoudadel54 marked this pull request as ready for review December 11, 2025 17:52
@tdipisa tdipisa added this to the 2025.02.01 milestone Dec 12, 2025
Copy link
Copy Markdown
Member

@tdipisa tdipisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahmoudadel54 it seems there are failing unit tests here. Please check. Thank you.

Copy link
Copy Markdown
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MV88
Copy link
Copy Markdown
Contributor

MV88 commented Dec 12, 2025

@mahmoudadel54 please fix this PR by rebasing with master

…ast feature is not anymore valid

Description:
- handle refresh wms layer if there is loading error
- add unit tests
@MV88 MV88 enabled auto-merge (squash) December 12, 2025 11:48
@MV88 MV88 requested review from tdipisa and removed request for tdipisa December 12, 2025 13:58
@MV88 MV88 merged commit a366cd4 into geosolutions-it:master Dec 12, 2025
6 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 12, 2025
…not anymore valid (#11804)

Description:
- handle refresh wms layer if there is loading error
- add unit tests

(cherry picked from commit a366cd4)
@github-actions
Copy link
Copy Markdown
Contributor

@ElenaGallo
Copy link
Copy Markdown
Contributor

Test passed, @tdipisa backport can be merged

tdipisa pushed a commit that referenced this pull request Dec 15, 2025
…not anymore valid (#11804) (#11818)

Description:
- handle refresh wms layer if there is loading error
- add unit tests

(cherry picked from commit a366cd4)

Co-authored-by: mahmoud adel <58145645+mahmoudadel54@users.noreply.github.com>
mahesh-wor pushed a commit to mahesh-wor/MapStore2 that referenced this pull request Dec 17, 2025
…ast feature is not anymore valid (geosolutions-it#11804)

Description:
- handle refresh wms layer if there is loading error
- add unit tests
allyoucanmap pushed a commit that referenced this pull request Mar 13, 2026
…not anymore valid (#11804) (#11818)

Description:
- handle refresh wms layer if there is loading error
- add unit tests

(cherry picked from commit a366cd4)

Co-authored-by: mahmoud adel <58145645+mahmoudadel54@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Time dimension: Reload not working, when the last feature is not anymore valid

4 participants