Fix #11754 - Moved assemply to bin-war module#11761
Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom Dec 2, 2025
Merged
Fix #11754 - Moved assemply to bin-war module#11761offtherailz merged 1 commit intogeosolutions-it:masterfrom
offtherailz merged 1 commit intogeosolutions-it:masterfrom
Conversation
tdipisa
approved these changes
Dec 2, 2025
Contributor
|
Successfully created backport PR for |
offtherailz
added a commit
that referenced
this pull request
Dec 3, 2025
dsuren1
added a commit
that referenced
this pull request
Dec 4, 2025
…request * commit 'a0da62e93ec7c7f9049c3343e410d4bea1db33c1': Update User Guide - Itinerary plugin (#11768) Fix the dashboard save, legend dependency and maximize issue (#11715) Update User Guide - Isochrone plugin (#11769) #11525 - Improve Maps in Dashboards (#11625) Update User Guide - Cascading search filter (#11766) Update User Guide - Show the current time and Null values options on Chart Widget (#11764) Fix #11754 - Moved assemply to bin-war module (#11761) Update User Guide - 3D Tiles imagery layers (#11758) Update User Guide - Update Tags menu section (#11756) Fix #11748 Access Restrictions for Maps Created from Unadvertised Contexts (#11752)
mahesh-wor
pushed a commit
to mahesh-wor/MapStore2
that referenced
this pull request
Dec 17, 2025
allyoucanmap
pushed a commit
that referenced
this pull request
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because of parent-child relationship introduced recently on bin package, during a full reactor build the
mapstore-binaryaggregator module executed the assembly plugin before thebin-warchild producedmapstore.waron the CI server.That means the ZIP created by the assembly could miss the WAR or copy an older artifact. Locally this was less visible because of incremental artifacts in the developer workspace.
What I changed
The assembly execution was moved from
binary/pom.xmlintobinary/bin-war/pom.xml.The assembly descriptor
binary/bin.xmlwas updated to use paths relative tobin-war(so it can includetarget/mapstore.war,target/jreandtarget/dependency).The assembly output directory was adjusted so the final ZIP lands in
binary/target/just like before.Why this fixes it: Putting assembly in
bin-warmakes the assembly run as part of thebin-warmodule lifecycle which is executed after packaging the WAR. This removes reactor ordering issues (parent pom executed before child modules) that previously allowed the assembly to run before the WAR existed on CI.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Fix #11754
What is the new behavior?
Bin build should be always done after war creation.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)