Skip to content

Isochrone panel enhancement#11674

Merged
allyoucanmap merged 3 commits intogeosolutions-it:masterfrom
dsuren1:#11437_enhance
Nov 13, 2025
Merged

Isochrone panel enhancement#11674
allyoucanmap merged 3 commits intogeosolutions-it:masterfrom
dsuren1:#11437_enhance

Conversation

@dsuren1
Copy link
Copy Markdown
Contributor

@dsuren1 dsuren1 commented Nov 12, 2025

Description

This PR enhances the Isochrone open/close panel behavior and resetting fields

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

Issue

What is the current behavior?

What is the new behavior?

  • Reset fields when reset and close panel
  • Run parameter clone copies correct direction

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added this to the 2025.02.00 milestone Nov 12, 2025
@dsuren1 dsuren1 requested a review from allyoucanmap November 12, 2025 07:13
@dsuren1 dsuren1 removed their assignment Nov 12, 2025
@dsuren1 dsuren1 linked an issue Nov 12, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is another problem not listed inside the comment:

  • when a user update the location the zoomToPoint actions is always zooming to level 12, I think we should review this by:
    • not perform zoomToPoint if the location is inside the visible map
    • perform zoomToPoint using the current zoom level of the map if the location is outside the visible map

@dsuren1 dsuren1 requested a review from allyoucanmap November 13, 2025 05:52
@allyoucanmap allyoucanmap merged commit 3a1ad81 into geosolutions-it:master Nov 13, 2025
6 checks passed
@allyoucanmap
Copy link
Copy Markdown
Contributor

@ElenaGallo please test this fix on dev and let us know if we can backport to 2025.02.xx, thanks.
Please check also if this has been solved in the test #11674 (review), thanks

@dsuren1 dsuren1 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 14, 2025
@ElenaGallo
Copy link
Copy Markdown
Contributor

Test passed, @dsuren1 please backport to 2025.02.xx. Thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Nov 19, 2025
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 19, 2025
tdipisa pushed a commit that referenced this pull request Nov 19, 2025
allyoucanmap pushed a commit that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Isochrone plugin implementation

4 participants