Fix: #11127 Enhance Dockerfile to build image from local source#11636
Conversation
|
do docker users of existing project do some operation to migrate their applications (e.g. workflows, build)? It looks to still work wit MAPSTORE_WEBAPP_SRC, but I'm asking ... I'd like to ask you to document how to use this docker instance. I see that the port changes from 8082 to 8080 on both binary and docker. |
There was a problem hiding this comment.
Can we document how to use this docker image?
I can not find the documentation anywere.
So maybe people have to check the docker file to know how to use (port, variables etc..)
Ideally it could be documented on dockerhub and linked from official documentation, but follow the best practice you think are fine.
Our documentation should say how to use them in the project.
|
I tested the build, it is okay. I also updated the document on README. About Dockerhub document, we can update it later and separately. |
offtherailz
left a comment
There was a problem hiding this comment.
Approved.
Maybe we should move this documentation for Readme to official documentation, that is anyway the reference for this contents.
But this can be done in a second time.
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#11127
What is the new behavior?
Dockerfileis now compatible with both the root MapStore project and custom MapStore projectscreateProject.jsscript has been updated to copy theDockerfileandbinary/tomcat/conf/server.xmlwhen generating a custom MapStore projectBreaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information