Hardening and cleaning up the UploadPluginController code#11623
Merged
Hardening and cleaning up the UploadPluginController code#11623
Conversation
axl8713
requested changes
Oct 28, 2025
Contributor
axl8713
left a comment
There was a problem hiding this comment.
LGTM.
Just minor code changes suggestions.
...s/src/main/java/it/geosolutions/mapstore/controllers/rest/config/UploadPluginController.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/it/geosolutions/mapstore/controllers/rest/config/UploadPluginController.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/it/geosolutions/mapstore/controllers/rest/config/UploadPluginController.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/it/geosolutions/mapstore/controllers/rest/config/UploadPluginController.java
Outdated
Show resolved
Hide resolved
java/services/src/test/java/it/geosolutions/mapstore/UploadPluginControllerTest.java
Outdated
Show resolved
Hide resolved
axl8713
approved these changes
Oct 28, 2025
dsuren1
added a commit
to dsuren1/MapStore2
that referenced
this pull request
Oct 29, 2025
* master: Hardening and cleaning up the UploadPluginController code (geosolutions-it#11623) Bump version of babel packages (geosolutions-it#11606) Fix: geosolutions-it#11403 In Dashboard , When table widget is connected to map and saved the app crashes (geosolutions-it#11475)
MV88
pushed a commit
that referenced
this pull request
Oct 30, 2025
* Hardening and cleaning up the UploadPluginController code * Code changes to improve readability. --------- Co-authored-by: Alessandro Ricchiuti <alessandro.ricchiuti@geosolutionsgroup.com>
MV88
pushed a commit
that referenced
this pull request
Oct 30, 2025
* Hardening and cleaning up the UploadPluginController code * Code changes to improve readability. --------- Co-authored-by: Alessandro Ricchiuti <alessandro.ricchiuti@geosolutionsgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleaning up and improving the UploadPluginController code by enforcing secutity on relative paths.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information