Skip to content

Fix #11497 Swipe state is not reset triggering pending changes in map viewer#11506

Merged
allyoucanmap merged 2 commits intogeosolutions-it:masterfrom
stefanocudini:11497-swipetool-state-not-reset
Sep 24, 2025
Merged

Fix #11497 Swipe state is not reset triggering pending changes in map viewer#11506
allyoucanmap merged 2 commits intogeosolutions-it:masterfrom
stefanocudini:11497-swipetool-state-not-reset

Conversation

@stefanocudini
Copy link
Copy Markdown
Member

@stefanocudini stefanocudini commented Sep 23, 2025 •
edited
Loading

Fix issue #11497

  • fix yellow circle button in SaveAs
  • the state of swipe tool il resetted for new map, The specific change for this part of the state is used to build the map configuration. We need to reset it on load to avoid false positives in the pendingChanges.
  • added unit test to cover the case of new map opened after a previous map with swipe tool active

Description

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
#11497 yellow circle compare on new map if previous map have swipe enabled

What is the new behavior?
for new map yellow badge is hidden

1_issue-solved.mp4

@stefanocudini stefanocudini self-assigned this Sep 23, 2025
@stefanocudini stefanocudini marked this pull request as draft September 23, 2025 14:43
@stefanocudini stefanocudini linked an issue Sep 23, 2025 that may be closed by this pull request
Swipe state is not reset triggering pending changes in map viewer #11497
Closed
1 task
@stefanocudini stefanocudini added this to the 2025.01.02 milestone Sep 23, 2025
@stefanocudini stefanocudini force-pushed the 11497-swipetool-state-not-reset branch from bcb1a21 to f33f8fc Compare September 24, 2025 10:12
@stefanocudini
fix handle button saveAs
25a4c01 
fix clear swipe changes on new map loaded
added swipe tests for new map condition

tentative new swipe epic for resetting swipe in new map
@stefanocudini stefanocudini force-pushed the 11497-swipetool-state-not-reset branch from f33f8fc to 25a4c01 Compare September 24, 2025 10:20
@stefanocudini stefanocudini marked this pull request as ready for review September 24, 2025 10:28
@stefanocudini stefanocudini changed the title fix yellow circle on button SaveAs Swipe state is not reset triggering pending changes in map viewer Sep 24, 2025
@stefanocudini stefanocudini changed the title Swipe state is not reset triggering pending changes in map viewer Fix #11497 Swipe state is not reset triggering pending changes in map viewer Sep 24, 2025
@allyoucanmap allyoucanmap merged commit 4583c7c into geosolutions-it:master Sep 24, 2025
9 of 10 checks passed
@allyoucanmap
Copy link
Copy Markdown
Contributor

allyoucanmap commented Sep 24, 2025

@ElenaGallo please test this fix on dev and let us know if we can backport to 2025.01.xx, thanks

@allyoucanmap allyoucanmap added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 24, 2025
@allyoucanmap
Copy link
Copy Markdown
Contributor

allyoucanmap commented Sep 25, 2025

Test passed, @stefanocudini please backport

stefanocudini added a commit to stefanocudini/MapStore2 that referenced this pull request Sep 25, 2025
@stefanocudini
Fix geosolutions-it#11497 Swipe state is not reset triggering pending…
ddab18d 
… changes in map viewer (geosolutions-it#11506)
allyoucanmap pushed a commit that referenced this pull request Sep 25, 2025
@stefanocudini
Fix #11497 Swipe state is not reset triggering pending changes in map…
6f16d85 
… viewer (#11506) (#11515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allyoucanmap allyoucanmap allyoucanmap approved these changes

Assignees

@stefanocudini stefanocudini

@allyoucanmap allyoucanmap

Labels

BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch bug

Projects

None yet

Milestone

2025.01.02

Development

Successfully merging this pull request may close these issues.

Swipe state is not reset triggering pending changes in map viewer

3 participants

@stefanocudini @allyoucanmap @tdipisa