Skip to content

Fix #11465 Problem with feedback mask and user permissions#11498

Merged
offtherailz merged 2 commits intogeosolutions-it:masterfrom
allyoucanmap:issue_11465
Sep 22, 2025
Merged

Fix #11465 Problem with feedback mask and user permissions#11498
offtherailz merged 2 commits intogeosolutions-it:masterfrom
allyoucanmap:issue_11465

Conversation

@allyoucanmap
Copy link
Copy Markdown
Contributor

@allyoucanmap allyoucanmap commented Sep 19, 2025

Description

This PR includes two fixes:

  • ensure the feedback mask uses portal to be render on top of everything
  • remove canCopy permissions to map with id but without info to hide SaveAs. This combination refers to inaccessible map

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

#11465

What is the new behavior?

The feedback mask covers the page to prevent unwanted actions

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

@allyoucanmap allyoucanmap added this to the 2025.01.02 milestone Sep 19, 2025
@allyoucanmap allyoucanmap self-assigned this Sep 19, 2025
@allyoucanmap allyoucanmap linked an issue Sep 19, 2025 that may be closed by this pull request
Problem with feedback mask and user permissions #11465
Closed
1 task
offtherailz
offtherailz requested changes Sep 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment •
edited by allyoucanmap
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my tests the page do not always work:

  • Trying to open in local do not prompt the login, showing empty page (on dev it works better)
Screencast.from.2025-09-19.13-11-26.webm
  • Same issue on logout
Screencast.from.2025-09-19.13-09-46.webm

@offtherailz offtherailz enabled auto-merge (squash) September 19, 2025 13:25
@offtherailz offtherailz merged commit 38ed583 into geosolutions-it:master Sep 22, 2025
14 of 17 checks passed
@allyoucanmap
Copy link
Copy Markdown
Contributor Author

allyoucanmap commented Sep 22, 2025

@ElenaGallo please test this fix on dev and let me know when I can backport to 2025.01.xx, thanks

allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this pull request Sep 25, 2025
@allyoucanmap
Fix geosolutions-it#11465 Problem with feedback mask and user permiss…
1c03275 
…ions (geosolutions-it#11498)
@allyoucanmap
Copy link
Copy Markdown
Contributor Author

allyoucanmap commented Sep 25, 2025

test passed

tdipisa pushed a commit that referenced this pull request Sep 25, 2025
@allyoucanmap
Fix #11465 Problem with feedback mask and user permissions (#11498) (#…
636935e 
…11516)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@offtherailz offtherailz offtherailz approved these changes

Assignees

@offtherailz offtherailz

@allyoucanmap allyoucanmap

Labels

bug Regression

Projects

None yet

Milestone

2025.01.02

Development

Successfully merging this pull request may close these issues.

Problem with feedback mask and user permissions

2 participants

@allyoucanmap @offtherailz