Fix #11489 Number editor no use standard editor superclass#11490
Merged
offtherailz merged 2 commits intogeosolutions-it:masterfrom Sep 17, 2025
Merged
Fix #11489 Number editor no use standard editor superclass#11490offtherailz merged 2 commits intogeosolutions-it:masterfrom
offtherailz merged 2 commits intogeosolutions-it:masterfrom
Conversation
allyoucanmap
approved these changes
Sep 17, 2025
Member
Author
|
@ElenaGallo, could you please test this on DEV ? Thank you |
offtherailz
added a commit
to offtherailz/MapStore2
that referenced
this pull request
Sep 17, 2025
1 task
Contributor
|
Test passed, @offtherailz please backport |
offtherailz
added a commit
that referenced
this pull request
Sep 17, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The problem was caused by the fact that NumberEditor overridden the
getInputNodemethod with a ref. This anyway does not work properly and causes the issue.The fix consists in taking the methods and features from superclass, incuding handling of other methods like blur and keydown.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#11489
What is the new behavior?
Fix #11489
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information