Performance Optimization: Refactor Pending Changes Logic and Save Resource Selector #11476#11484
Merged
allyoucanmap merged 9 commits intogeosolutions-it:masterfrom Sep 19, 2025
Merged
Conversation
…t in debounce manner
allyoucanmap
requested changes
Sep 17, 2025
Contributor
allyoucanmap
left a comment
There was a problem hiding this comment.
I pushed additional code that needs to be tested and reviewed in addition some tests are failing and they need to be reviewed
This was
linked to
issues
Sep 19, 2025
allyoucanmap
approved these changes
Sep 19, 2025
Contributor
|
@ElenaGallo please test these fixes on dev and let use know if we can backport on 2025.01.xx, thanks. |
Contributor
|
Test passed, @rowheat02 please backport to 2025.01.xx . Thanks |
rowheat02
added a commit
to rowheat02/MapStore2
that referenced
this pull request
Sep 22, 2025
…11458 Performance Optimization: Refactor Pending Changes Logic and Save Resource Selector geosolutions-it#11476 (geosolutions-it#11484) --------- Co-authored-by: allyoucanmap <stefano.bovio@geosolutionsgroup.com>
allyoucanmap
added a commit
that referenced
this pull request
Sep 22, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
fixes #11476
fixes #11435
fixes #11458
What is the current behavior?
#11476
#11435
#11458
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
Screen.Recording.2025-09-16.at.20.07.36.mov
compareMapChangesis out of selector and is called using debounce logic. Managed inuseComputedPendingChangesAnother expensive function, ' saveMapConfiguration`, is only called on demand. Will not be called infinitely while doing UI/Map Interaction
for Optimization, createSelector has been used on the main selector
Also, now, while saving a new or existing map, the mapSave payload is calculated, unlike before, taking from the selector.