Skip to content

#11397: Fix TOC layer-settings description disappears when switching between tabs#11398

Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom
congchen1101:fix_layer_settings_description_disappears
Dec 18, 2025
Merged

#11397: Fix TOC layer-settings description disappears when switching between tabs#11398
offtherailz merged 1 commit intogeosolutions-it:masterfrom
congchen1101:fix_layer_settings_description_disappears

Conversation

@congchen1101
Copy link
Copy Markdown
Contributor

@congchen1101 congchen1101 commented Aug 22, 2025

fix(TOC layer-settings): preserve description when switching between tabs

  • Fixed an issue where a layer’s description shown in the General tab disappeared after navigating to the Style tab and back
  • Prevent overwriting description if capabilities.Abstract is empty or undefined
  • Add test to verify description persistence when Abstract is missing

On behalf of DB Systel GmbH

Description

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

What is the current behavior?

#11397

What is the new behavior?
Layer’s description will not disappear after navigating to the Style tab and back

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

@cc1101
geosolutions-it#11397
0fa1cbb 
fix(TOC layer-settings): preserve description when switching between tabs

- Fixed an issue where a layer’s description shown in the General tab
  disappeared after navigating to the Style tab and back
- Prevent overwriting description if capabilities.Abstract is empty or undefined
- Add test to verify description persistence when Abstract is missing

On behalf of DB Systel GmbH
@tdipisa tdipisa linked an issue Aug 22, 2025 that may be closed by this pull request
TOC: Layer description disappears after switching between General and Style tabs in Layer Settings #11397
Closed
1 task
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Aug 22, 2025

@congchen1101 thank you for your contribution. Anyway, I've checked on the same map you indicated in the connected issue but I'm not reproducing the problem. All seems working as expected. Are there maybe other preconditions to respect to reproduce the problem?

@tdipisa tdipisa mentioned this pull request Aug 22, 2025
Closed
1 task
@tdipisa tdipisa requested a review from allyoucanmap August 22, 2025 13:56
@tdipisa tdipisa added bug BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch External Contribution labels Aug 22, 2025
@tdipisa tdipisa added this to the 2025.01.02 milestone Aug 22, 2025
@congchen1101
Copy link
Copy Markdown
Contributor Author

congchen1101 commented Aug 22, 2025

Hi @tdipisa,
thanks for checking. Please make sure the selected layer already has a description, but that this description does not come from the corresponding GeoServer abstract field. Then switch to the Style tab and back to General—you should see the issue.

The video I shared was recorded today, and I have just checked again — the bug is still present when performing the exact steps on the layer poly_landmarks. There are no other preconditions and this layer should meet all the required conditions.

@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Aug 28, 2025
@tdipisa tdipisa modified the milestones: 2025.01.02, 2025.02.00 Aug 28, 2025
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 4, 2025
@tdipisa tdipisa modified the milestones: 2025.02.00, 2025.02.01 Nov 4, 2025
@tdipisa tdipisa added backport 2025.02.xx and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Dec 12, 2025
@tdipisa tdipisa assigned offtherailz and unassigned allyoucanmap Dec 18, 2025
@tdipisa tdipisa requested review from offtherailz and removed request for allyoucanmap December 18, 2025 09:40
@offtherailz offtherailz reopened this Dec 18, 2025
@offtherailz
Copy link
Copy Markdown
Member

offtherailz commented Dec 18, 2025

Nice.
Thank you very much for your contribution. 👍 ❤️

@offtherailz offtherailz enabled auto-merge (squash) December 18, 2025 10:46
@offtherailz offtherailz merged commit 9d999b9 into geosolutions-it:master Dec 18, 2025
24 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 18, 2025
@congchen1101 @github-actions
#11397 (#11398)
5a4408b 
(cherry picked from commit 9d999b9)
@github-actions github-actions bot mentioned this pull request Dec 18, 2025
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 18, 2025

Successfully created backport PR for 2025.02.xx:

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Dec 18, 2025

Thank you so much @congchen1101. @ElenaGallo please let us know for the backport. Thank you.

@ElenaGallo
Copy link
Copy Markdown
Contributor

ElenaGallo commented Dec 19, 2025 •
edited
Loading

Test passed on DEV, @offtherailz backport can be merged here: #11830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@offtherailz offtherailz offtherailz approved these changes

Assignees

@offtherailz offtherailz

Labels

backport 2025.02.xx bug External Contribution ready

Projects

None yet

Milestone

2025.02.01

Development

Successfully merging this pull request may close these issues.

TOC: Layer description disappears after switching between General and Style tabs in Layer Settings

7 participants

@congchen1101 @tdipisa @offtherailz @ElenaGallo @allyoucanmap @MariaBanti @cc1101