#11395: Fix TOC group is not restored in correct position when it has no direct child layer#11396
Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom Dec 18, 2025
Conversation
fix(TOC): ensure groups without direct layers are restored in correct position - Fixed an issue where newly created groups without direct child layers, but containing subgroups with layers, were not displayed in the correct position after saving - Added test cases to cover groups with only subgroups On behalf of DB Systel GmbH
1 task
offtherailz
approved these changes
Dec 18, 2025
Member
offtherailz
left a comment
There was a problem hiding this comment.
I confirm, the algorithm looks correct to determine the sort order.
@ElenaGallo Here a map to replicate the issue.
Importing this on dev will cause the test2 group to go to the bottom.
With the fix, the test2 group goes correctly in the middle.
@congchen1101 thank you very much for the fix 👍
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2025
fix(TOC): ensure groups without direct layers are restored in correct position - Fixed an issue where newly created groups without direct child layers, but containing subgroups with layers, were not displayed in the correct position after saving - Added test cases to cover groups with only subgroups On behalf of DB Systel GmbH Co-authored-by: CongChen <cong.chen.mz@gmail.com> (cherry picked from commit 4108074)
Contributor
|
Successfully created backport PR for |
Contributor
|
Test passed on DEV, @offtherailz backport can be merged here: #11831 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TOC groups without direct layers should be restored in correct position
On behalf of DB Systel GmbH
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#11395
What is the new behavior?
Group without direct child layer is stored in correct position.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)