Extend the charts to show the current time#11348
Merged
offtherailz merged 11 commits intogeosolutions-it:masterfrom Jul 23, 2025
Merged
Extend the charts to show the current time#11348offtherailz merged 11 commits intogeosolutions-it:masterfrom
offtherailz merged 11 commits intogeosolutions-it:masterfrom
Conversation
offtherailz
requested changes
Jul 21, 2025
Member
There was a problem hiding this comment.
The functionality works 👍
Anyway I'd ask you some changes to improve readability and compatibility.
- Use dependencies. We can not add a parameter on every new dependency. For this reason there is a dependency mapping system and several enhancer that allows to get values for dependencies and update the widget every time it . I'd suggest a "dependenciesToShapes" enhancer that checks timeRange dependency (the flag and it s settings, to draw the shapes on the chart).
- Name not simply range but timeRange
- Maybe it is the case to allow to select also the style of the line, when checked (size, dash style and color).
offtherailz
requested changes
Jul 22, 2025
Member
There was a problem hiding this comment.
- For options and labels, instead of spread generic shapeColor, shapeSize, shapeStyle, use an object
currentTimeOpts: {style, size, color}or we can confuse with other shapes. - For labels, shape style etc... is confusing. I suggest to use color, style and size, and group them, something like this shold work
final effect (replace labels with simply "Color" "Style" and "Size"
offtherailz
approved these changes
Jul 23, 2025
Member
|
@ElenaGallo, could you please test this on DEV ? Thank you |
Contributor
|
@subashtiwari1010 When the "Show the current time on the axis" option is enabled, the highlighted date on the timeline is January 1st, 2021 instead of the current date. Used this map for testing. 
|
Member
|
Hi @ElenaGallo , current time looks to be January 1st, 2021 in the map you provided: 
and the layer looks to contain some data for the given value. 
So it looks ok to me |
subashtiwari1010
added a commit
to subashtiwari1010/MapStore2
that referenced
this pull request
Jul 31, 2025
offtherailz
pushed a commit
that referenced
this pull request
Aug 1, 2025
ale-cristofori
pushed a commit
that referenced
this pull request
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the functionality to display the current time in the charts, issue #11326. It adds the checkbox to display the current time in the Axes tab of the charts.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
There is no option to add the current time in the chart.
Fixes #11326
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information