Fix #11103 Update cesium to latest stable 1.131.0 , reviewed all the cesium layers and cesium map. by anup39 · Pull Request #11331 · geosolutions-it/MapStore2

anup39 · 2025-07-18T10:11:38Z

Description

Updated Cesium to latest stable , review cesium layers and map to be compatible with latest version.

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
Tests for the changes have been added (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

Minor changes to existing features

Issue

What is the current behavior?

#11103

What is the new behavior?

Cesium have been updated to latest stable 1.131.0
removed deprecated methods like ready and readyPromise from the cesium layers
Updated the GeoServerBILTerrainProvider to behave similar to CesiumTerrainProvider
SingleTileImageryProvider constructor parameters options.tileHeight and options.tileWidth became required.
Fix for the ArcGIS Layer in Cesium .
Changed the test case failing as Cesium Changed behavior of DataSourceDisplay.ready to always stay true once it is initially set to true https://github.com/CesiumGS/cesium/blob/main/CHANGES.md#1126---2025-02-03
Overlay Layer is fixed with addition of isDestroyed method. This is now required to make the InfoWindow compatible with Cesium Primitive interface. https://github.com/CesiumGS/cesium/blob/1.131/packages/engine/Source/Scene/Primitive.js#L2436

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

No

Other useful information

…o latest stable 1.131.0

… upgrade to latest stable

…x_cesium_upgrade_11103

…eady to always stay true once it is initially set to true

…ory to create the Single Tile

dsuren1

@anup39
Overall, the changes look fine. However, I still noticed some residual use of _ready in a few places. Kindly review and include the necessary updates along with the other requested amendments

dsuren1 · 2025-07-22T11:21:36Z

web/client/components/map/cesium/plugins/TerrainLayer.js

-            url: Cesium.IonResource.fromAssetId(options.assetId, {
-                accessToken: options.accessToken,
-                server: options.server
+        ...(config.options.assetId && {


const options = config.options ?? {};

Suggested change

...(config.options.assetId && {

...(options.assetId && {

I’d recommend using optional chaining to make the implementation more robust in cases where config might be undefined. Also, consider reverting this particular change and add options to the existing object

dsuren1 · 2025-07-22T11:23:12Z

web/client/components/map/cesium/plugins/TerrainLayer.js

+        url = WMSUtils.wmsToCesiumOptionsBIL(config).url;
+        options = WMSUtils.wmsToCesiumOptionsBIL(config) || {};


Suggested change

url = WMSUtils.wmsToCesiumOptionsBIL(config).url;

options = WMSUtils.wmsToCesiumOptionsBIL(config) || {};

const cesiumOptionsBIL = WMSUtils.wmsToCesiumOptionsBIL(config);

url = cesiumOptionsBIL.url;

options = cesiumOptionsBIL || {};

Kindly avoid calling it twice when the param is same, as some operations can be expensive and can impact performance

dsuren1 · 2025-07-22T11:27:08Z

web/client/components/map/cesium/plugins/TerrainLayer.js

+        url = cesiumOptionsMapping(config).url;
+        options = cesiumOptionsMapping(config).options || {};


Suggested change

url = cesiumOptionsMapping(config).url;

options = cesiumOptionsMapping(config).options || {};

const cesiumOptions = cesiumOptionsMapping(config);

url = cesiumOptions.url;

options = cesiumOptions.options || {};

dsuren1 · 2025-07-22T11:27:45Z

web/client/components/map/cesium/plugins/TerrainLayer.js

+        url =  cesiumIonOptionsMapping(config).url;
+        options = cesiumIonOptionsMapping(config).options || {};


Suggested change

url = cesiumIonOptionsMapping(config).url;

options = cesiumIonOptionsMapping(config).options || {};

const ionOptions = cesiumIonOptionsMapping(config);

url = ionOptions.url;

options = ionOptions.options || {};

anup39 · 2025-07-23T07:20:42Z

@anup39 Overall, the changes look fine. However, I still noticed some residual use of _ready in a few places. Kindly review and include the necessary updates along with the other requested amendments

GraticuleLayer

ModifyGeoJSONInteraction

@dsuren1 I have removed _ready usage in these particular files and also made other necessary changes.

dsuren1 · 2025-07-23T09:47:24Z

web/client/components/map/cesium/plugins/TerrainLayer.js

+        const ionOptions = cesiumIonOptionsMapping(config);
+        url = ionOptions.url;
+        options = ionOptions.options || {};
+        terrainProvider = Cesium.CesiumTerrainProvider.fromUrl(url, options);


Suggested change

terrainProvider = Cesium.CesiumTerrainProvider.fromUrl(url, options);

if (url) {

terrainProvider = Cesium.CesiumTerrainProvider.fromUrl(url, options);

}

in cesium-ion, there’s a possibility that the assetId might be missing or incorrect, which could result in an undefined URL and subsequently an exception when retrieving the provider. Kindly ensure that similar edge cases are also handled gracefully

dsuren1 · 2025-07-23T12:52:26Z

@ElenaGallo Kindly test this in DEV, when available. Thanks!

anup39 added 5 commits July 17, 2025 18:01

Fix:geosolutions-it#11103 Reviewed cesium layers and cesium upgrade t…

316edac

…o latest stable 1.131.0

removed debug message

7e51a84

Fix: Arcgis cesium layer: resource object was missing when cesium was…

58ce773

… upgrade to latest stable

Fix: testcases for different layers in cesium

407d450

Merge branch 'master' of github.com:geosolutions-it/MapStore2 into fi…

3aa5ffe

…x_cesium_upgrade_11103

anup39 added this to the 2025.02.00 milestone Jul 18, 2025

anup39 self-assigned this Jul 18, 2025

anup39 added enhancement 3D All issues related to the 3D rendering in CesiumJs labels Jul 18, 2025

anup39 linked an issue Jul 18, 2025 that may be closed by this pull request

Update CesiumJS dependency to latest stable #11103

Closed

1 task

anup39 added 3 commits July 18, 2025 19:00

Fix: test case because Cesium Changed behavior of DataSourceDisplay.r…

bad1a76

…eady to always stay true once it is initially set to true

Fix : failing test case where tileWidth and tileHeight are now mandat…

f141489

…ory to create the Single Tile

fix:Typo

52e8416

anup39 requested a review from allyoucanmap July 18, 2025 13:45

tdipisa requested review from dsuren1 and removed request for allyoucanmap July 21, 2025 12:47

fix : Arcgislayer and overlay layer

a49c8f8

dsuren1 requested changes Jul 22, 2025

View reviewed changes

anup39 added 3 commits July 22, 2025 19:18

Removed duplication of function call and added optional chaining

1f1a5ee

fix: change in varialbe name

a77d6ae

fix: Remove ready from Geojson Edit in cesium

1bdccd3

anup39 requested a review from dsuren1 July 23, 2025 07:20

dsuren1 requested changes Jul 23, 2025

View reviewed changes

added edge cases to check url before creating the terrainprovider

9ab7d3e

anup39 requested a review from dsuren1 July 23, 2025 10:05

dsuren1 approved these changes Jul 23, 2025

View reviewed changes

dsuren1 merged commit fe89aa0 into geosolutions-it:master Jul 23, 2025
6 checks passed

		url = WMSUtils.wmsToCesiumOptionsBIL(config).url;
		options = WMSUtils.wmsToCesiumOptionsBIL(config) \|\| {};

-        url = WMSUtils.wmsToCesiumOptionsBIL(config).url;
-        options = WMSUtils.wmsToCesiumOptionsBIL(config) || {};
+        const cesiumOptionsBIL = WMSUtils.wmsToCesiumOptionsBIL(config);
+        url = cesiumOptionsBIL.url;
+        options = cesiumOptionsBIL || {};

		url = cesiumOptionsMapping(config).url;
		options = cesiumOptionsMapping(config).options \|\| {};

-        url = cesiumOptionsMapping(config).url;
-        options = cesiumOptionsMapping(config).options || {};
+        const cesiumOptions = cesiumOptionsMapping(config);
+        url = cesiumOptions.url;
+        options = cesiumOptions.options || {};

		url = cesiumIonOptionsMapping(config).url;
		options = cesiumIonOptionsMapping(config).options \|\| {};

Conversation

anup39 commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue

Breaking change

Other useful information

Uh oh!

dsuren1 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anup39 commented Jul 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dsuren1 commented Jul 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anup39 commented Jul 18, 2025 •

edited

Loading

dsuren1 left a comment •

edited

Loading