Skip to content

#11270: fix - Layer groups visibility is not consistent with Map Visualization MapViews plugin#11313

Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:issue_11270
Jul 15, 2025
Merged

#11270: fix - Layer groups visibility is not consistent with Map Visualization MapViews plugin#11313
offtherailz merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:issue_11270

Conversation

@mahmoudadel54
Copy link
Copy Markdown
Contributor

Description

This PR includes handling ensure layers update on group visibility changes by modifying updateMapViewsLayers epic to explicitly include layers in updates when their associated group's visibility changes according to the selected map view. This edit resolve the issue of not consistency of layer groups in map view visulaization.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#11270

What is the new behavior?

mapviews.mp4

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

…t with Map Visualization MapViews plugin

Description:
- handle ensure layers update on group visibility changes by modifying `updateMapViewsLayers` epic to explicitly include layers in updates when their associated group's visibility changes according to the selected map view
- edit unit test
- add util 'findGroupById'
Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a problem reviewing this PR.

It is that I can not reproduce the issue anymore, on dev.

Can you verify if the issue is reproducible on dev ?

If I understood correctly, the turning on and off the group, the change was not propagated to the sub-layers. Isn't it?

But if you see @ale-cristofori here on dev, in the context you provided, the issue is not present anymore. I don't see it even in stable ...

Video.del.2025-07-15.17-08-38.mp4

Did I missed something? Did the issue disappeared? Can you please show me the difference between the 2 behaviors?

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Jul 15, 2025

@mahmoudadel54 we need you on the above asap as we are approaching QA functional tests soon this week.

@mahmoudadel54
Copy link
Copy Markdown
Contributor Author

I have a problem reviewing this PR.

It is that I can not reproduce the issue anymore, on dev.

Can you verify if the issue is reproducible on dev ?

If I understood correctly, the turning on and off the group, the change was not propagated to the sub-layers. Isn't it?

But if you see @ale-cristofori here on dev, in the context you provided, the issue is not present anymore. I don't see it even in stable ...

Video.del.2025-07-15.17-08-38.mp4
Did I missed something? Did the issue disappeared? Can you please show me the difference between the 2 behaviors?

@offtherailz
Here make sure to make groups hidden from toc first then check the mapview

https://dev-mapstore.geosolutionsgroup.com/mapstore/#/context/testVLAANDEREN1995/58558

I have updated your context to reproduce it.

@offtherailz
Copy link
Copy Markdown
Member

I also noticed that the issue was not reproducible because the context provided for test contained the user session plugin . This was dynamically changing the map saved and so the initial condition, making the "steps to reproduce" reported not valid.

I removed the user session plugin from the context in order to avoid confusion.

@offtherailz offtherailz merged commit b8efff4 into geosolutions-it:master Jul 15, 2025
6 checks passed
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Jul 15, 2025

@ElenaGallo please test in DEV and let us know if we can backport to stable tomorrow.

@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jul 15, 2025
@ElenaGallo
Copy link
Copy Markdown
Contributor

Test passed, @mahmoudadel54 please backport to 2025.01.xx. Thanks

@mahmoudadel54
Copy link
Copy Markdown
Contributor Author

Test passed, @mahmoudadel54 please backport to 2025.01.xx. Thanks

Backport is done --> #11323

tdipisa pushed a commit that referenced this pull request Jul 16, 2025
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MapViews plugin in contexts - Layer groups visibility is not consistent with Map Visualization

4 participants