fix #11153: fix keeping slider swipe position after saving resource#11280
Merged
MV88 merged 1 commit intogeosolutions-it:masterfrom Jul 4, 2025
Merged
fix #11153: fix keeping slider swipe position after saving resource#11280MV88 merged 1 commit intogeosolutions-it:masterfrom
MV88 merged 1 commit intogeosolutions-it:masterfrom
Conversation
1 task
12 tasks
MV88
approved these changes
Jul 4, 2025
Contributor
|
@ElenaGallo please test it in DEV |
Contributor
|
Test passed, @mahmoudadel54 please backport to 2025.01.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Jul 4, 2025
tdipisa
pushed a commit
that referenced
this pull request
Jul 4, 2025
…after saving resource (#11276, #11280) (#11284) * fix #1153: Persist Swipe Layer state after map refresh (#11276) * fix #1153: - handle storing position of swipe - fix issue of not reflecting the stored swipe - add unit tests * - add comment for swipe plugin in product/plugins.js - adjust indentation in swipe reducers * fix #11153 keeping swipe position after saving (#11280)
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Jul 4, 2025
tdipisa
pushed a commit
that referenced
this pull request
Jul 4, 2025
…tion after saving resource (#11276, #11280) (#11286) * fix #1153: Persist Swipe Layer state after map refresh (#11276) * fix #1153: - handle storing position of swipe - fix issue of not reflecting the stored swipe - add unit tests * - add comment for swipe plugin in product/plugins.js - adjust indentation in swipe reducers * fix #11153 keeping swipe position after saving (#11280)
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Jul 7, 2025
tdipisa
pushed a commit
that referenced
this pull request
Jul 7, 2025
…tion after saving resource (#11276, #11280) (#11293) * fix #11153: Persist Swipe Layer state after map refresh (#11276) * fix #11153: - handle storing position of swipe - fix issue of not reflecting the stored swipe - add unit tests * - add comment for swipe plugin in product/plugins.js - adjust indentation in swipe reducers * fix #11153 keeping swipe position after saving (#11280)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue of not keeping slider swipe position after saving and make refresh page for vertical/horizontal swipe.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#11276 (comment)
What is the new behavior?
Slider swipe position after saving resource is kept for horizontal/vertical slider.
persist.slider.pos.mp4
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information