Skip to content

#10699: Attribute table crash when additional geometries in attributes#11266

Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:issue_10699
Jul 3, 2025
Merged

#10699: Attribute table crash when additional geometries in attributes#11266
offtherailz merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:issue_10699

Conversation

@mahmoudadel54
Copy link
Copy Markdown
Contributor

Description

This PR includes: fixing the crash app issue due to multi geometry fields by

  • editing 'isGeometryType' util
  • editing 'describeFeatureTypeToAttributes' util

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#10699

What is the new behavior?

The new bahavior is if there are some multi geometry fields in layer data and user wants to explore attribute table data --> the geometry field will be the first one on fetched fields and other geometry ones will be ignored

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

…es in attributes

- fix the crash app issue due to multi geometry fields by editing 'isGeometryType' util and 'describeFeatureTypeToAttributes' util
- add unit tests
@mahmoudadel54 mahmoudadel54 added this to the 2025.01.01 milestone Jul 2, 2025
@mahmoudadel54 mahmoudadel54 requested a review from offtherailz July 2, 2025 07:11
@mahmoudadel54 mahmoudadel54 self-assigned this Jul 2, 2025
@mahmoudadel54 mahmoudadel54 added bug BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Jul 2, 2025
@mahmoudadel54 mahmoudadel54 linked an issue Jul 2, 2025 that may be closed by this pull request
1 task
Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me. No crashes anymore.

@offtherailz offtherailz merged commit a72b6c9 into geosolutions-it:master Jul 3, 2025
9 of 10 checks passed
@offtherailz
Copy link
Copy Markdown
Member

offtherailz commented Jul 3, 2025

@ElenaGallo, could you please test this on DEV ?
I created this Map https://dev-mapstore.geosolutionsgroup.com/mapstore/#/viewer/58653 for testing.
Here exported map.json

By opening the feature grid, dev (and I think also QA, when imported) was crashing. After this fix it works.
Thank you

@ElenaGallo
Copy link
Copy Markdown
Contributor

Test passed, @mahmoudadel54 please backport to 2025.01.xx. Thanks

@mahmoudadel54
Copy link
Copy Markdown
Contributor Author

Test passed, @mahmoudadel54 please backport to 2025.01.xx. Thanks

Backport is done --> #11307

@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attribute table crash when additional geometries in attributes

4 participants