Skip to content

#11252: Replace font-awesome icon with glyphicon#11261

Merged
allyoucanmap merged 4 commits intogeosolutions-it:masterfrom
dsuren1:#11252_fa_icon
Jul 10, 2025
Merged

#11252: Replace font-awesome icon with glyphicon#11261
allyoucanmap merged 4 commits intogeosolutions-it:masterfrom
dsuren1:#11252_fa_icon

Conversation

@dsuren1
Copy link
Copy Markdown
Contributor

@dsuren1 dsuren1 commented Jul 1, 2025

Description

This PR removes the use font-awesome from Resource Catalog component and replaces them with glyphicon alternates

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

Issue

What is the current behavior?

What is the new behavior?
The resource catalog page uses only glyphicon

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added this to the 2025.01.01 milestone Jul 1, 2025
@dsuren1 dsuren1 requested a review from allyoucanmap July 1, 2025 05:55
@dsuren1 dsuren1 self-assigned this Jul 1, 2025
@dsuren1 dsuren1 added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Jul 1, 2025
@dsuren1 dsuren1 linked an issue Jul 1, 2025 that may be closed by this pull request
Replace font-awesome icon with glyphicon #11252
Closed
@dsuren1 dsuren1 mentioned this pull request Jul 1, 2025
Merged
@allyoucanmap
Copy link
Copy Markdown
Contributor

allyoucanmap commented Jul 10, 2025

@dsuren1 I reviewed the style of the resource card action button and I added some missing glyphs:

  • shield
  • context
  • document
  • dataset

dataset, document and context glyphs should be used in geonode for the resource types

allyoucanmap
allyoucanmap requested changes Jul 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsuren1 could you please solve the failing tests?

@dsuren1 dsuren1 requested a review from allyoucanmap July 10, 2025 14:13
@allyoucanmap allyoucanmap merged commit 5a95d70 into geosolutions-it:master Jul 10, 2025
5 checks passed
@allyoucanmap
Copy link
Copy Markdown
Contributor

allyoucanmap commented Jul 10, 2025

@ElenaGallo please test these changes on dev and let us know when we can backport, thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Jul 11, 2025
@dsuren1
geosolutions-it#11252: Replace font-awesome icon with glyphicon (geos…
0cc65e1 
…olutions-it#11261)
@dsuren1 dsuren1 mentioned this pull request Jul 11, 2025
Merged
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jul 11, 2025
tdipisa pushed a commit that referenced this pull request Jul 11, 2025
@dsuren1
[Backport 2025.01.xx] #11252: Replace font-awesome icon with glyphicon (
10dd90f 
#11261) (#11306)

* #11252: Replace font-awesome icon with glyphicon (#11261)

* refactor icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allyoucanmap allyoucanmap allyoucanmap approved these changes

Assignees

@dsuren1 dsuren1

Labels

enhancement

Projects

None yet

Milestone

2025.01.01

Development

Successfully merging this pull request may close these issues.

Replace font-awesome icon with glyphicon

3 participants

@dsuren1 @allyoucanmap @tdipisa