#10930: fix Annotation circle editing causing MapStore to crash#11255
Merged
MV88 merged 1 commit intogeosolutions-it:masterfrom Jun 30, 2025
Merged
#10930: fix Annotation circle editing causing MapStore to crash#11255MV88 merged 1 commit intogeosolutions-it:masterfrom
MV88 merged 1 commit intogeosolutions-it:masterfrom
Conversation
… to crash - handle prevent crash on null inputRef in IntlNumberFormControl of Radius/Lat/Lng number inputs of annotations
1 task
Contributor
|
@ElenaGallo please test it in DEV |
Contributor
|
Test passed, @mahmoudadel54 please backport to 2025.01.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Jul 4, 2025
… to crash (geosolutions-it#11255) - handle prevent crash on null inputRef in IntlNumberFormControl of Radius/Lat/Lng number inputs of annotations
tdipisa
pushed a commit
that referenced
this pull request
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes fixing app crash during annotation circle editing.
The problem was the
IntlNumberFormControlcomponent was prone to crashing under certain conditions, specifically whenthis.state.inputRefwasnullorundefinedwithin thecomponentDidUpdatelifecycle method here:MapStore2/web/client/components/I18N/IntlNumberFormControl.jsx
Line 48 in f34f22c
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10930
What is the new behavior?
No crash for app during annotation circle editing will happen
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information