Skip to content

Thousands separator is always active while Mapstore is in French #10639#11248

Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom
rowheat02:fix-numberseperator
Jun 30, 2025
Merged

Thousands separator is always active while Mapstore is in French #10639#11248
offtherailz merged 1 commit intogeosolutions-it:masterfrom
rowheat02:fix-numberseperator

Conversation

@rowheat02
Copy link
Copy Markdown
Contributor

@rowheat02 rowheat02 commented Jun 27, 2025

Description

Now, the display of numbers will automatically adapt to the language the user selects.

Examples of sample formats for different languages:

1,234.56 in English (en-US)
1.234,56 in Italian (it-IT) and German (de-DE)
1 234,56 in French (fr-FR) (note: uses a non-breaking space)
1234,56 in Spanish (es-ES)

**Please check if the PR fulfills these requirements **

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

fixes #10639
fixes #10640

What is the current behavior?

#10639
#10640

What is the new behavior?

  • Number formats according to the language selected.
    image
  • Decimal value will not disappear as before

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Now, the React widget's NumberPicker has been replaced by IntlNumberFormControl.
To maintain the consistent style, the className of the React widget's 'rw-input` has been used.

@rowheat02 rowheat02 added this to the 2025.01.01 milestone Jun 27, 2025
@rowheat02 rowheat02 self-assigned this Jun 27, 2025
@rowheat02 rowheat02 added the bug label Jun 27, 2025
@rowheat02 rowheat02 marked this pull request as ready for review June 27, 2025 10:26
@tdipisa tdipisa requested a review from offtherailz June 27, 2025 11:12
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 27, 2025
@offtherailz offtherailz merged commit 656613e into geosolutions-it:master Jun 30, 2025
6 checks passed
@offtherailz
Copy link
Copy Markdown
Member

offtherailz commented Jun 30, 2025

@ElenaGallo, could you please test this on DEV ? Thank you

(BOTH THE ISSUES LINKED)

@ElenaGallo
Copy link
Copy Markdown
Contributor

ElenaGallo commented Jul 4, 2025

Test passed, @rowheat02 please backport to 2025.01.xx. Thanks

rowheat02 added a commit to rowheat02/MapStore2 that referenced this pull request Jul 4, 2025
@rowheat02
fix: NumberPicker of react widget in Advance query with IntlNumberFor…
3f23bbb 
…mControl (geosolutions-it#11248)

fixes geosolutions-it#10639
fixes geosolutions-it#10640
@rowheat02 rowheat02 mentioned this pull request Jul 4, 2025
Merged
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jul 4, 2025
tdipisa pushed a commit that referenced this pull request Jul 4, 2025
@rowheat02
fix: NumberPicker of react widget in Advance query with IntlNumberFor…
609e378 
…mControl (#11248) (#11288)

fixes #10639
fixes #10640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@offtherailz offtherailz offtherailz approved these changes

Assignees

@rowheat02 rowheat02

Labels

bug

Projects

None yet

Milestone

2025.01.01

Development

Successfully merging this pull request may close these issues.

Filtering a layer on a decimal attribute hides decimals Thousands separator is always active while Mapstore is in French

4 participants

@rowheat02 @offtherailz @ElenaGallo @tdipisa