Skip to content

#11164: make bar chart legend clickable by items#11167

Merged
allyoucanmap merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:issue_11164
Jun 3, 2025
Merged

#11164: make bar chart legend clickable by items#11167
allyoucanmap merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:issue_11164

Conversation

@mahmoudadel54
Copy link
Copy Markdown
Contributor

Description

This PR handles toggle legend items for bar charts by adding property 'groupclick' by 'toggleitem' to enable toggle items in legend for bar charts in Plotly.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
#11164

What is the new behavior?

toggle.items.legend.mp4

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

https://plotly.com/javascript/reference/layout/#layout-legend-groupclick

- add property 'groupclick' by 'toggleitem' to enable toggle items in legend for bar charts
@mahmoudadel54 mahmoudadel54 self-assigned this Jun 3, 2025
@mahmoudadel54 mahmoudadel54 linked an issue Jun 3, 2025 that may be closed by this pull request
1 task
@tdipisa tdipisa added this to the 2025.01.01 milestone Jun 3, 2025
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 3, 2025
@allyoucanmap allyoucanmap merged commit 250ec32 into geosolutions-it:master Jun 3, 2025
5 checks passed
@allyoucanmap
Copy link
Copy Markdown
Contributor

@ElenaGallo please test this fix on dev, thanks

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Jun 3, 2025

@ElenaGallo @mahmoudadel54 the backport can happen to 2025.01.xx only after v2025.01.00

@ElenaGallo
Copy link
Copy Markdown
Contributor

Test passed, @mahmoudadel54 please backport to 2025.01.xx. Thanks

@mahmoudadel54
Copy link
Copy Markdown
Contributor Author

Test passed, @mahmoudadel54 please backport to 2025.01.xx. Thanks

Backport is done ---> #11203

@mahmoudadel54 mahmoudadel54 removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bar Chart legend items not clickable?

4 participants