Fix #10966 adjusted many requests to include headers#11133
Merged
tdipisa merged 3 commits intogeosolutions-it:masterfrom Jun 6, 2025
Merged
Fix #10966 adjusted many requests to include headers#11133tdipisa merged 3 commits intogeosolutions-it:masterfrom
tdipisa merged 3 commits intogeosolutions-it:masterfrom
Conversation
allyoucanmap
requested changes
Jun 3, 2025
| useEffect(() => { | ||
| const authMethod = getAuthenticationMethod(src); | ||
|
|
||
| const headers = getAuthorizationBasic(props?.layer?.security?.sourceId); |
Contributor
There was a problem hiding this comment.
please move this inside the else if (props?.layer?.security?.sourceId) { statement because this is needed only in the case
allyoucanmap
approved these changes
Jun 6, 2025
Member
|
@ElenaGallo please repeat the same functional tests on DEV instance. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is including almost all changes (some of them were already in master branch) from:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Fix #10966
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information