Update gfi & legend#11121
Merged
tdipisa merged 3 commits intogeosolutions-it:c027-2024.01.xxfrom May 21, 2025
Merged
Conversation
allyoucanmap
requested changes
May 21, 2025
Comment on lines
+34
to
+35
| const headers = getAuthorizationBasic(props?.layer?.security?.sourceId); | ||
| if (props.layer) { |
Contributor
There was a problem hiding this comment.
I think the layer will be always true so probably the other else if have no effect with this implementation.
Shouldn't we access this first if only if props?.layer?.security is not undefined and sourceId is available?
allyoucanmap
approved these changes
May 21, 2025
b41e345
into
geosolutions-it:c027-2024.01.xx
4 of 5 checks passed
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We noticed that GFI and get legend graphics were missing the basic auth
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information