#8338: Implement a terrain layer selector#11087
Merged
allyoucanmap merged 14 commits intogeosolutions-it:masterfrom Jul 9, 2025
Merged
#8338: Implement a terrain layer selector#11087allyoucanmap merged 14 commits intogeosolutions-it:masterfrom
allyoucanmap merged 14 commits intogeosolutions-it:masterfrom
Conversation
Description: - create new components with the new UI for layer selector - adding terrain selector in case 3D cesium - add unit tests - add translation
…in background components - add translations
2 tasks
allyoucanmap
requested changes
Jun 11, 2025
- remove editable option from save layer - add terrain options to layer.options instead of layer object root level - add crs options and version options for terrain layer selector for wms - handle show radio button icon for terrain - remove tempLayer/currentLayer that not used - edit tooltip appearance for background selector - remove unused props in BackgroundSelector - remove un-used css files in background like previewicon.css / previewbutton.css - edit unit tests
allyoucanmap
requested changes
Jun 30, 2025
Contributor
allyoucanmap
left a comment
There was a problem hiding this comment.
@mahmoudadel54 here I have pushed some changes in this commit 120b934 to complete the PR we need to:
- updated JSDoc of BackgroundSelector by removing the configuration not supported anymore and include description of items support
- check locally that my changes did not introduced errors
- provide a fix if unit tests will fail
thanks
…fig and BackgroundSelector plugin - add/fix unit tests - fix adding terrain layer to map - fix choosing first terrain layer after delete current terrain
allyoucanmap
approved these changes
Jul 9, 2025
Contributor
|
@ElenaGallo please test this new feature on dev, thanks |
Member
|
Hi @ElenaGallo it would be good if you can proceed with testing this on DEV asap today or tomorrow. |
Contributor
|
Test passed, @mahmoudadel54 please backport. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#8338
What is the current behavior?
#8338
What is the new behavior?
recording1.mp4
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information