widgets in map wrongly align with a specific config #10676#10681
Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom Nov 18, 2024
Merged
widgets in map wrongly align with a specific config #10676#10681offtherailz merged 1 commit intogeosolutions-it:masterfrom
offtherailz merged 1 commit intogeosolutions-it:masterfrom
Conversation
1 task
offtherailz
approved these changes
Nov 18, 2024
Member
offtherailz
left a comment
There was a problem hiding this comment.
It works for me.
Looks to be simply an old part of code missing. approved
Member
|
@ElenaGallo, could you please test this on DEV ? Thank you |
Contributor
|
Test passed, @rowheat02 please backport to 2024.02.xx. Thanks |
rowheat02
added a commit
to rowheat02/MapStore2
that referenced
this pull request
Nov 21, 2024
tdipisa
pushed a commit
that referenced
this pull request
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ignored rowheight from config(cfg) to calculate the baseheight of widget in small screens(isSingleWidgetLayout)
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
#10676
What is the current behavior?
#10676
What is the new behavior?
In small screens, widget will not hide partially.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information