Skip to content

Returning wrong pixel xy value on mousemove for leaflet engine#10677

Merged
tdipisa merged 1 commit intogeosolutions-it:masterfrom
shivadas1980:wrong_pixel_xy_value
Nov 15, 2024
Merged

Returning wrong pixel xy value on mousemove for leaflet engine#10677
tdipisa merged 1 commit intogeosolutions-it:masterfrom
shivadas1980:wrong_pixel_xy_value

Conversation

@shivadas1980
Copy link
Copy Markdown
Contributor

@shivadas1980 shivadas1980 commented Nov 14, 2024 •
edited by tdipisa
Loading

Description

On mouse move over map using leaflet engine, it returns wrong pixel xy value. It always return x value for x and y.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

**On mouse move on map using leaflet engine, return x pixel value for both x and y pixel value. **
#

What is the new behavior?

After this fix, on mouse move over map return correct xy pixel value for leaflet engine

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@tdipisa tdipisa requested a review from allyoucanmap November 14, 2024 10:36
@tdipisa tdipisa added this to the 2024.02.02 milestone Nov 14, 2024
@tdipisa tdipisa added External Contribution BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Nov 14, 2024
@tdipisa tdipisa merged commit f5ec4f3 into geosolutions-it:master Nov 15, 2024
allyoucanmap pushed a commit to allyoucanmap/MapStore2 that referenced this pull request Nov 15, 2024
@shivadas1980 @allyoucanmap
Returning wrong pixel xy value on mousemove for leaflet engine (geoso…
6436a22 
…lutions-it#10677)

Co-authored-by: Shivendra Das <shivendra.das@cz1cg1.pri>
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 15, 2024
tdipisa pushed a commit that referenced this pull request Nov 15, 2024
@allyoucanmap @shivadas1980
Returning wrong pixel xy value on mousemove for leaflet engine (#10677)…
cf7bf33 
… (#10679)

Co-authored-by: shivadas1980 <shivendradas@gmail.com>
Co-authored-by: Shivendra Das <shivendra.das@cz1cg1.pri>
@ash03e608
Copy link
Copy Markdown

ash03e608 commented Nov 15, 2024

Hello @tdipisa , @allyoucanmap ,
This MR has been submitted from a team at Halliburton who is currently using Mapstore via the JS API. We are currently evaluating the stability of the Mapstore JS API and hence we are interested to know the history of this bug and if this was a recent regression. If not, is this a bug thats only exposed on the JS API and not via the React components. Since the workflow is fundamental and the error very obvious, i wanted to hear your thoughts on it.

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Nov 15, 2024 •
edited
Loading

@ash03e608 it is not a recent regression. That incorrect setup was introduced many years ago by this PR #1211, it seems.
Probably because Leaflet map engine is less used and supported than OL/Cesium ones, this issue has never been reported before. Thank you very much for using MapStore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allyoucanmap allyoucanmap allyoucanmap approved these changes

Assignees

@shivadas1980 shivadas1980

Labels

External Contribution

Projects

None yet

Milestone

2024.02.02

Development

Successfully merging this pull request may close these issues.

4 participants

@shivadas1980 @ash03e608 @tdipisa @allyoucanmap